Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: separate the build_test into two different jobs to save time #2079

Merged
merged 7 commits into from
Jul 3, 2024
Merged

chore: separate the build_test into two different jobs to save time #2079

merged 7 commits into from
Jul 3, 2024

Conversation

iOvergaard
Copy link
Collaborator

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard marked this pull request as ready for review July 2, 2024 12:58
@iOvergaard iOvergaard added ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup labels Jul 2, 2024
madsrasmussen
madsrasmussen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@iOvergaard iOvergaard disabled auto-merge July 3, 2024 07:01
@iOvergaard iOvergaard merged commit 6d58cdf into main Jul 3, 2024
6 of 7 checks passed
@iOvergaard iOvergaard deleted the chore/build-and-test-jobs branch July 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
ignore-for-release Pull requests that will not be included in the automated release notes. internal Changes that do not affect the runtime files, e.g. changes to the build setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iOvergaard @madsrasmussen