Feature: Link Picker modal refactor #2477
Merged
+284
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to remove the `:` suffix (from all languages)
Swaps the inline trees with input pickers. Makes use of `<umb-property-layout>` component. + plenty of TLC in the UI/UX!
e.g. folders are not selectable
As it is widely supported: https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static#browser_compatibility
madsrasmussen
requested changes
Oct 23, 2024
There was a problem hiding this comment.
It looks great!
I have a few minor UX tweaks for consistency. Firstly, we can remove the "Edit" action on the reference list items since we can already click on the name to achieve the same result. Additionally, we should follow the same convention inside the link picker modal when a document is selected. We should remove the "Open" action and make it possible to click the name.
as the `uui-ref-node` link title will open the edit modal. Refactored, so that the `uui-action-bar` isn't rendered in `readonly` mode.
as the `uui-ref-node` link title will open the edit workspace modal (if configured). Refactored, so that the `uui-action-bar` isn't rendered in `readonly` mode.
|
Thanks @madsrasmussen! Changes made...
|
This was referenced Oct 23, 2024
Link node selection does not auto generate a link title in the backoffice.
umbraco/Umbraco-CMS#16596
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A refactoring of the Link Picker modal UI.
Fixes and new features include...
hideTargetflaguui-ref-nodecomponent<umb-property-layout>component for UI consistencyFixes umbraco/Umbraco-CMS#16838
Fixes umbraco/Umbraco-CMS#16596
Fixes umbraco/Umbraco-CMS#17016
Types of changes
How to test?
Test using either the Multi-URL Picker, TinyMCE or Tiptap editors. Can you add external links, pick a document or media item? Add, edit existing data, etc.
Screenshots (if appropriate)
Recording.2024-10-22.181543.mp4