Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: 17434 (prevent routable modals inside not routable modals) #2518

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 6, 2024

Prevent context consumption of route-context from a modal that is not routable. Making routableModals never construct a path and thereby not valid.

This is breaking in the sense if someone wanted to retrieve the Route Context from a not-routable-modal. But this is not what we want pr. default.

If you still like to do so you have to consume the context with .passContextAliasMatches() enabled on your consumption.

fixes umbraco/Umbraco-CMS#17434

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe changed the base branch from main to release/15.0 November 6, 2024 20:47
@nielslyngsoe nielslyngsoe merged commit da73567 into release/15.0 Nov 7, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/hotfix/modal-route-context-boundary branch November 7, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

15-rc: Block Editors: Unable to create a Settings model in the flow of setting up a new block
2 participants