Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update php and laravel requirements #8

Closed
wants to merge 5 commits into from

Conversation

jamesrusso
Copy link

bump to support php 8.1 and laravel 10. This was done since this was a downstream dependency of ltree.

pvsaintpe
pvsaintpe previously approved these changes Sep 17, 2023
@pvsaintpe
Copy link
Member

pvsaintpe commented Sep 17, 2023

@jamesrusso

Has the handling of presenters changed in Laravel 10? The coverage dropped ( https://coveralls.io/builds/62705298 ) because the tests don't work anymore. I need time to investigate what the problem is. And then I'm dying branches in all repositories.

@jamesrusso
Copy link
Author

@jamesrusso

Has the handling of presenters changed in Laravel 10? The coverage dropped ( https://coveralls.io/builds/62705298 ) because the tests don't work anymore. I need time to investigate what the problem is. And then I'm dying branches in all repositories.

Not sure. I'll try and spend some time on it today.

@jamesrusso
Copy link
Author

@jamesrusso
Has the handling of presenters changed in Laravel 10? The coverage dropped ( https://coveralls.io/builds/62705298 ) because the tests don't work anymore. I need time to investigate what the problem is. And then I'm dying branches in all repositories.

Not sure. I'll try and spend some time on it today.

The unit tests and locally are showing no tests run. I've made some additional commits to this PR to handle some some other dep updates.

@jamesrusso
Copy link
Author

Looking back to 2020, I do not think the coverage was ever good on this project?

@pvsaintpe
Copy link
Member

added support php 8.1/8.2 and laravel

@pvsaintpe pvsaintpe closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants