Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/search-directive-invalid-element #44

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

grimurd
Copy link

@grimurd grimurd commented Apr 26, 2019

renderer wants a element reference but search directive was sending native element instead

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #44 into develop will decrease coverage by 0.39%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #44     +/-   ##
==========================================
- Coverage    20.82%   20.42%   -0.4%     
==========================================
  Files            1        1             
  Lines          317      328     +11     
  Branches        66       69      +3     
==========================================
+ Hits            66       67      +1     
- Misses         244      254     +10     
  Partials         7        7
Impacted Files Coverage Δ
...les/ngx-magic-search/ngx-magic-search.component.ts 20.42% <9.09%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4860709...7f8579d. Read the comment docs.

@grimurd grimurd closed this Apr 26, 2019
@grimurd grimurd deleted the bugfix/search-directive-invalid-element branch April 26, 2019 11:32
@grimurd grimurd restored the bugfix/search-directive-invalid-element branch April 26, 2019 11:39
@grimurd grimurd reopened this Apr 26, 2019
@grimurd grimurd changed the title Bugfix/search directive invalid element bugfix/search-directive-invalid-element Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant