Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/initialize-facets (BREAKING CHANGE) #46

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

grimurd
Copy link

@grimurd grimurd commented Apr 26, 2019

BREAKING CHANGE

Added the feature to initialize the component with pre-selected facets.

Removed everything to do with storing the facets in the page URL.

Why?

  • It was doing all the URL using browser APIs instead of Angular APIs which is contradictory to best practices.
  • It could conflict with any query params that the user has
  • Unneccessarily complicated. Simple is better.

If the user want's to store the facets in the URL he can do so himself easily using angular router.

Also removed everything todo with updating the URL
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #46 into develop will decrease coverage by 1.85%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
- Coverage    20.82%   18.96%   -1.86%     
===========================================
  Files            1        1              
  Lines          317      290      -27     
  Branches        66       59       -7     
===========================================
- Hits            66       55      -11     
+ Misses         244      231      -13     
+ Partials         7        4       -3
Impacted Files Coverage Δ
...les/ngx-magic-search/ngx-magic-search.component.ts 18.96% <12.5%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4860709...c450422. Read the comment docs.

Also had to change how and when facets are initialized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant