-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Selenium support (4.13 -> 4.15) #34
base: master
Are you sure you want to change the base?
Conversation
@rbourga You are the local expert here. WDYT? |
Question: given that JMeter is compatible with Java 8 but that Selenium 4.15 requires Java 11, how will this plugin work on JMeter 5.6.2 installations on Java 8? Can you explain minimum requirements if we wish to install the new 4.15 plugin? What will current users on Java 8 need to do ? Will they still be able to download the old 4.13 version if 4.15 gets out in case their company is still on Java 8 ? |
Suggestion: if we specifiy something like "Version 4.15 requires Java 11 or higher; for Java 8, download version 4.13." in the "changes" field of the jpc-plugins.json file of jmeter-plugins repo, can this be an acceptable solution? |
I'm afraid that many people install latest plugin in automation, so no chance they will see it. Even those using UI might not pay attention. |
Hey. Long story short: I don't see a valid reason to stay on 4.13 or Java 8 if one chooses to keep using the jpgc driver. Reason being selenium itself and the fact that e.g. the Chromedriver version currently is at 119 - which isn't even supported at all and I can see people wanting to update to use it.
I personally like the suggestion. I mean if some choose to stay with Java 8 and/or don't need Chromedriver > 117 (just to stay with the example) they can still choose to fix the version they download for usage at jpgc-webdriver=4.13.0.0 On top of all that, JMeter 5.6 does support Java 8+ and as far as I can tell it works well with Java 11. Well these are my two cents. I'm sure you guys have more expertise. But thank you for even considering. Edit: I don't see why the jpgc-webdriver should be constrained. I think it should offer the ability to upgrade and support newer (or the newest) selenium driver. If users update should be their own decision. |
@Ageneh , I can understand your frustration. But given Java 8 is still one of the most widely used versions (as of Jan 2022), especially in enterprise environments, we must take backwards compatibility into account. There are a mix of different reasons why a lot of companies are still stuck with Java 8 JRE and, as Undera says, people would click on the "update" button straight away without reading the Java 11 requirement, which would then result in their scripts failing, causing a lot of havoc! |
FYI, I have opened a ticket on JMeter to move on to Java 11. |
@undera , here's response from JMeter Group: "JMeter supports running with Java 8..21, so it should be fine if some plugins require Java 11." What if we release the new WedDriver plugin in JMeter 5.6 with the note that the plugin requires Java 11 as initially suggested? |
That's basically what implicitly meant when I wrote "they can still choose to fix the version they download for usage at jpgc-webdriver=4.13.0.0". Thank you for opening the issue! |
My past experience says that the compatibility issues are very real in JMeter ecosystem. WebDriver is very popular plugin, so I expect a lot of people to get into this compatibility problem. |
I am getting the following "warning" But I think is bigger than a warning. Chrome 126 is only compatible with Selenium 4.22 us of today 7/12/2024, and JMeter plugin driver is still at 4:13. So I think it needs to be updated to be compatible with 4.22, is this correct?WARNING: Unable to find version of CDP to use for 126.0.6478.127. You may need to include a dependency on a specific version of the CDP using something similar to |
@undera I was struggling with our JMeter/Selenium setup this past week and after a lot of debugging found our issues. We want to run on Chrome 119 but [email protected] doesnt support it.
So I decided to look into your project.
Would be great if this pull request could be merged since my team relies on the jpgc-webdriver.