Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selenium support (4.13 -> 4.15) #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ageneh
Copy link

@Ageneh Ageneh commented Dec 2, 2023

@undera I was struggling with our JMeter/Selenium setup this past week and after a lot of debugging found our issues. We want to run on Chrome 119 but [email protected] doesnt support it.
So I decided to look into your project.
Would be great if this pull request could be merged since my team relies on the jpgc-webdriver.

@undera
Copy link
Owner

undera commented Dec 4, 2023

@rbourga You are the local expert here. WDYT?

@rbourga
Copy link
Contributor

rbourga commented Dec 4, 2023

Question: given that JMeter is compatible with Java 8 but that Selenium 4.15 requires Java 11, how will this plugin work on JMeter 5.6.2 installations on Java 8? Can you explain minimum requirements if we wish to install the new 4.15 plugin? What will current users on Java 8 need to do ? Will they still be able to download the old 4.13 version if 4.15 gets out in case their company is still on Java 8 ?
Thanks.

@rbourga
Copy link
Contributor

rbourga commented Dec 5, 2023

Suggestion: if we specifiy something like "Version 4.15 requires Java 11 or higher; for Java 8, download version 4.13." in the "changes" field of the jpc-plugins.json file of jmeter-plugins repo, can this be an acceptable solution?

@undera
Copy link
Owner

undera commented Dec 5, 2023

I'm afraid that many people install latest plugin in automation, so no chance they will see it. Even those using UI might not pay attention.
I guess we have to wait for base JMeter to support Java 11.

@Ageneh
Copy link
Author

Ageneh commented Dec 5, 2023

Hey. Long story short: I don't see a valid reason to stay on 4.13 or Java 8 if one chooses to keep using the jpgc driver. Reason being selenium itself and the fact that e.g. the Chromedriver version currently is at 119 - which isn't even supported at all and I can see people wanting to update to use it.

Suggestion: if we specifiy something like "Version 4.15 requires Java 11 or higher; for Java 8, download version 4.13." in the "changes" field of the jpc-plugins.json file of jmeter-plugins repo, can this be an acceptable solution?

I personally like the suggestion. I mean if some choose to stay with Java 8 and/or don't need Chromedriver > 117 (just to stay with the example) they can still choose to fix the version they download for usage at jpgc-webdriver=4.13.0.0

On top of all that, JMeter 5.6 does support Java 8+ and as far as I can tell it works well with Java 11.

Well these are my two cents. I'm sure you guys have more expertise. But thank you for even considering.

Edit: I don't see why the jpgc-webdriver should be constrained. I think it should offer the ability to upgrade and support newer (or the newest) selenium driver. If users update should be their own decision.

@rbourga
Copy link
Contributor

rbourga commented Dec 5, 2023

@Ageneh , I can understand your frustration. But given Java 8 is still one of the most widely used versions (as of Jan 2022), especially in enterprise environments, we must take backwards compatibility into account. There are a mix of different reasons why a lot of companies are still stuck with Java 8 JRE and, as Undera says, people would click on the "update" button straight away without reading the Java 11 requirement, which would then result in their scripts failing, causing a lot of havoc!
I think it is more prudent to wait for the core JMeter to require Java 11 before releasing plugins that would require Java 11 before JMeter itself.

@rbourga
Copy link
Contributor

rbourga commented Dec 8, 2023

FYI, I have opened a ticket on JMeter to move on to Java 11.
Let's see what happens!
Issue 6172

@rbourga
Copy link
Contributor

rbourga commented Dec 8, 2023

@undera , here's response from JMeter Group:

"JMeter supports running with Java 8..21, so it should be fine if some plugins require Java 11."
Also, apparently, the next major release JMeter 6.0 would require Java 17.

What if we release the new WedDriver plugin in JMeter 5.6 with the note that the plugin requires Java 11 as initially suggested?
If people running on Java 8 accidentally upgrade to the 4.15 plugin, they still have possibility to revert back to version 4.13 (or to install Java 11).

@Ageneh
Copy link
Author

Ageneh commented Dec 11, 2023

If people running on Java 8 accidentally upgrade to the 4.15 plugin, they still have possibility to revert back to version 4.13 (or to install Java 11).

That's basically what implicitly meant when I wrote "they can still choose to fix the version they download for usage at jpgc-webdriver=4.13.0.0".

Thank you for opening the issue!

@undera
Copy link
Owner

undera commented Dec 11, 2023

My past experience says that the compatibility issues are very real in JMeter ecosystem. WebDriver is very popular plugin, so I expect a lot of people to get into this compatibility problem.

@NicoSan25
Copy link

I am getting the following "warning" But I think is bigger than a warning. Chrome 126 is only compatible with Selenium 4.22 us of today 7/12/2024, and JMeter plugin driver is still at 4:13. So I think it needs to be updated to be compatible with 4.22, is this correct?

WARNING: Unable to find version of CDP to use for 126.0.6478.127. You may need to include a dependency on a specific version of the CDP using something similar to org.seleniumhq.selenium:selenium-devtools-v86:4.13.0 where the version ("v86") matches the version of the chromium-based browser you're using and the version number of the artifact is the same as Selenium's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants