Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UD-1647: update marvin tags and pull policy to use floating tags #302

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

knrc
Copy link
Contributor

@knrc knrc commented Jul 29, 2024

Description

Update the marvin plugin configuration to use a floating tag

Linked Issues

How has this been tested?

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@knrc knrc added the enhancement New feature or request label Jul 29, 2024
@matheusfm matheusfm self-requested a review July 30, 2024 12:58
@matheusfm
Copy link
Contributor

Depends on undistro/marvin#63

@matheusfm
Copy link
Contributor

Since undistro/marvin#63 is merged, I think we should only merge this PR when the image ghcr.io/undistro/marvin:v0.2 exists

@knrc
Copy link
Contributor Author

knrc commented Jul 30, 2024

Since undistro/marvin#63 is merged, I think we should only merge this PR when the image ghcr.io/undistro/marvin:v0.2 exists

That would only be relevant if someone is running from the github charts, and then they can override if necessary

@knrc knrc merged commit 6134732 into undistro:main Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants