Add items argument to menus #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in unfulvio#18 it's helpfull to get the slug of the referenced object in some cases (e.g. custom routing). Now every item and possible children have an `object_slug` field. In case of custom links it just returns the items slug since the id refers to the item it self. Note that the v1 implementation isn't tested. Closes unfulvio#18
In some cases the cost of fetching the menus first and then only fetching the childs for the menus that are needed by id are higher then fetching them all at once. It's now possible to specify an `items` argument to indicate whether to fetch the menu items aswell or not. This could be also helpfull in cases like [this](https://wordpress.org/support/topic/get-menu-data-by-name-not-id) to filter on the client, although a `slug` argument to filter the menus array in addition would be need. Note that this change is currently V2 only.
|
Note that this PR is already based on #28. |
|
@mckernanin I would merge this but I think it would be great if I could get a second per of eyes before that. Could you give a quick review? Let me know if you need any additional information or context to make this easier for you. |
|
I will check it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the cost of fetching the menus first and then only fetching the items for the menus that are needed by id are higher then fetching them all at once. It's now possible to specify an
itemsargument to indicate whether to fetch the menu items as well or not.Since it defaults to false this change would be non breaking.
Note that this change is currently V2 only.