-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ARM architecture #42
Conversation
support arm architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Only two formatting nitpicks, and one question. Otherwise looks good if the pipeline passes.
Note to self: I’ll have to re-tag on main
(or update to a newer Stack version here and in Artemis) to publish a new image that supports both architectures.
Co-authored-by: Benedikt Fein <[email protected]>
Co-authored-by: Benedikt Fein <[email protected]>
@b-fein thanks for approving, sometimes the pipeline fails because it takes too long and GitHub thinks it has lost connection. Just rerunning the job worked for me if I saw |
The action keeps failing because GitHub kills it, if GitHub would support ARM runners (or you have a self-hosted one), the arm image would build, just check my fork, it worked there. |
Co-authored-by: Benedikt Fein <[email protected]>
During my Artemis development I noticed that I could not create/manage any haskell exercises due to my computer's architecture. This PR adds a QEMU step and publishes images for amd and arm.
The QEMU build takes about 1h and 20 minutes