Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ARM architecture #42

Merged
merged 7 commits into from
Nov 13, 2023
Merged

feat: add support for ARM architecture #42

merged 7 commits into from
Nov 13, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Nov 12, 2023

During my Artemis development I noticed that I could not create/manage any haskell exercises due to my computer's architecture. This PR adds a QEMU step and publishes images for amd and arm.

The QEMU build takes about 1h and 20 minutes

Copy link
Member

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Only two formatting nitpicks, and one question. Otherwise looks good if the pipeline passes.


Note to self: I’ll have to re-tag on main (or update to a newer Stack version here and in Artemis) to publish a new image that supports both architectures.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
reschandreas and others added 2 commits November 12, 2023 12:47
Co-authored-by: Benedikt Fein <[email protected]>
Co-authored-by: Benedikt Fein <[email protected]>
@reschandreas
Copy link
Contributor Author

@b-fein thanks for approving, sometimes the pipeline fails because it takes too long and GitHub thinks it has lost connection. Just rerunning the job worked for me if I saw The hosted runner: GitHub Actions 2 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@reschandreas
Copy link
Contributor Author

The action keeps failing because GitHub kills it, if GitHub would support ARM runners (or you have a self-hosted one), the arm image would build, just check my fork, it worked there.

Co-authored-by: Benedikt Fein <[email protected]>
@b-fein b-fein changed the title Add support for ARM architecture feat: add support for ARM architecture Nov 13, 2023
@b-fein b-fein merged commit 4fcca81 into uni-passau-artemis:main Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants