Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information Exposure #4049

Merged
merged 17 commits into from
Oct 14, 2024
Merged

Information Exposure #4049

merged 17 commits into from
Oct 14, 2024

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Jul 16, 2024 •
edited by azure-boards bot
Loading

AB#207787 Information Exposure

@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (0fade38) to head (1d54a2d).
Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/household/views.py 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4049      +/-   ##
===========================================
- Coverage    77.80%   77.50%   -0.31%     
===========================================
  Files          931      932       +1     
  Lines        44286    44287       +1     
===========================================
- Hits         34457    34324     -133     
- Misses        9829     9963     +134
Flag Coverage Δ
e2e 52.13% <43.47%> (-2.55%) ⬇️
unittests 76.38% <95.65%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domdinicola domdinicola enabled auto-merge (squash) September 2, 2024 08:07
@domdinicola
Copy link
Collaborator

@johniak can we finish this?

@pavlo-mk pavlo-mk self-assigned this Oct 11, 2024
@pavlo-mk pavlo-mk marked this pull request as draft October 11, 2024 13:05
@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Oct 11, 2024
@pavlo-mk pavlo-mk changed the title AB#207787 Information Exposure WIP // AB#207787 Information Exposure Oct 11, 2024
@pavlo-mk pavlo-mk changed the title WIP // AB#207787 Information Exposure WIP // Information Exposure Oct 11, 2024
@domdinicola
Copy link
Collaborator

@pavlo-mk can you adjust the migrations?

@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Oct 11, 2024
@pavlo-mk pavlo-mk changed the title WIP // Information Exposure Information Exposure Oct 11, 2024
@pavlo-mk pavlo-mk marked this pull request as ready for review October 11, 2024 13:28
@domdinicola
Copy link
Collaborator

@pavlo-mk can you fix the tests?

@domdinicola
Copy link
Collaborator

@pavlo-mk test fails again

@pavlo-mk pavlo-mk requested review from patryk-dabrowski and removed request for patryk-dabrowski October 14, 2024 12:58
@domdinicola domdinicola merged commit 7304670 into develop Oct 14, 2024
13 checks passed
@domdinicola domdinicola deleted the feature/AB#207787-Information-Exposure branch October 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkujawa pkujawa pkujawa approved these changes

@domdinicola domdinicola Awaiting requested review from domdinicola

@MarekBiczysko MarekBiczysko Awaiting requested review from MarekBiczysko

@patryk-dabrowski patryk-dabrowski Awaiting requested review from patryk-dabrowski

Assignees

@pavlo-mk pavlo-mk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johniak @domdinicola @patryk-dabrowski @pkujawa @pavlo-mk