Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor payment plan exclude beneficiaries for people #4208

Merged

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Sep 9, 2024

AB#213815: Not possible to exclude from payment plan with IND id in people programme
AB#214280: FE bugs

@pavlo-mk pavlo-mk added backend Changes in BE code frontend Changes in FE code work in progress Change doesn't need to be reviewed labels Sep 9, 2024
@pavlo-mk pavlo-mk self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (ef0ee8c) to head (78aa755).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4208      +/-   ##
===========================================
- Coverage    83.67%   83.28%   -0.40%     
===========================================
  Files          416      416              
  Lines        33104    33113       +9     
  Branches      5490     5491       +1     
===========================================
- Hits         27700    27577     -123     
- Misses        4469     4599     +130     
- Partials       935      937       +2     
Flag Coverage Δ
e2e 53.76% <52.00%> (-2.78%) ⬇️
nightly-e2e ?
unittests 81.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk closed this Sep 11, 2024
@pavlo-mk pavlo-mk reopened this Sep 11, 2024
@mmaciekk mmaciekk force-pushed the refactor_payment_plan_exclude_beneficiaries_for_people branch from 9e8eb04 to 32c522e Compare September 18, 2024 09:49
@mmaciekk mmaciekk self-assigned this Sep 18, 2024
@mmaciekk mmaciekk changed the title WIP // Refactor payment plan exclude beneficiaries for people Refactor payment plan exclude beneficiaries for people Sep 18, 2024
@mmaciekk mmaciekk removed the work in progress Change doesn't need to be reviewed label Sep 18, 2024
@mmaciekk mmaciekk marked this pull request as ready for review September 18, 2024 11:06
@mmaciekk mmaciekk merged commit 01db5f9 into develop Sep 20, 2024
13 checks passed
@mmaciekk mmaciekk deleted the refactor_payment_plan_exclude_beneficiaries_for_people branch September 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code frontend Changes in FE code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants