Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP // OLD PR...... : Supporting documents #4241

Closed
wants to merge 14 commits into from

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Sep 17, 2024

THIS ONE WILL CLOSE....

NEW PR >>>> here 4250

AB#190339: Payment Module - Enable user to upload supporting documents

updates:

  1. paymentPlan added supportingDocuments:
image
  1. new endpoints api/rest/swagger/
image

url example:
http://localhost:3000/api/rest/afghanistan/programs/UHJvZ3JhbU5vZGU6MDAwMDAwMDAtMDAwMC0wMDAwLTAwMDAtZmFjZWIwMGMwMDAw/payment-plans/UGF5bWVudFBsYW5Ob2RlOjAwMDAwMDAwLWZlZWQtYmVlZi0wMDAwLTAwMDAwYmFkZjAwZA%3D%3D/supporting-documents/3/

@pavlo-mk pavlo-mk added backend Changes in BE code frontend Changes in FE code work in progress Change doesn't need to be reviewed labels Sep 17, 2024
@pavlo-mk pavlo-mk self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.30%. Comparing base (ef0ee8c) to head (cd6a3d6).

Files with missing lines Patch % Lines
...ackend/hct_mis_api/apps/payment/api/serializers.py 90.47% 1 Missing and 1 partial ⚠️
backend/hct_mis_api/apps/payment/models.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4241      +/-   ##
===========================================
- Coverage    83.66%   83.30%   -0.37%     
===========================================
  Files          416      417       +1     
  Lines        33104    33180      +76     
  Branches      5490     5495       +5     
===========================================
- Hits         27697    27639      -58     
- Misses        4470     4602     +132     
- Partials       937      939       +2     
Flag Coverage Δ
e2e 53.76% <60.75%> (-2.78%) ⬇️
unittests 81.81% <96.20%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk force-pushed the 190339_Payment_plan_supporting_documents branch from 6ec9885 to d2daeb7 Compare September 24, 2024 10:19
@pavlo-mk pavlo-mk changed the title WIP // PM: Supporting documents WIP // OLD PR...... : Supporting documents Sep 24, 2024
@pavlo-mk pavlo-mk closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code frontend Changes in FE code work in progress Change doesn't need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant