Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17760 syr, delete obsolete decimalFormats/currencyFormats without numberSystem #4292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedberg-icu
Copy link
Contributor

CLDR-17760

  • This PR completes the ticket.

In syr, delete the obsolete <decimalFormats> and <currencyFormats> elements that do not have a numberSystem attribute at all (these probably date from when the syr data was first added in xml to the seed directory years ago). These do not show up in Survey Tool and (I think) are ignored by ICU code. The current version of these elements does have a numberSystem attribute, and syr does also have <decimalFormats> and <currencyFormats> elements (and also <percentFormats>) with numberSystem="latn"; these are the ones that appear in Survey Tool and get used by the code.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this Jan 17, 2025
@AEApple
Copy link
Contributor

AEApple commented Jan 18, 2025

How does deprecation of structure work in other languages? I'm assuming that at some point in the past there was only one script possible per locale and there was no option to have a number format per language.

Either way if the data is unconfirmed that in theory no one is likely to be using it, but I'd like to understand the larger context because I've seen unconfirmed data elsewhere in locales that aren't vetted by any organization and are unlikely to be vetted by guest vetters either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants