Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DurationFormatter: Fix Digital Data SourceDataProvider #5280

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

kartva
Copy link
Member

@kartva kartva commented Jul 23, 2024

follow up to #5208

SourceDataProvider incorrectly generated the following padding data for h:mm:ss:

 "hms_padding": {
    "h": 1,
    "m": 1,
    "s": 1
  },

This was due to an oversight in using split_once which consumes the character used to split. From split_once documentation: assert_eq!("cfg=foo".split_once('='), Some(("cfg", "foo")));

Previous code incorrectly assumed the splitting character was not consumed.
This PR rectifies the error and regenerates testdata and bakeddata.

@kartva kartva marked this pull request as ready for review July 23, 2024 17:54
@kartva kartva requested review from sffc, robertbastian, Manishearth and a team as code owners July 23, 2024 17:54
@kartva kartva requested review from younies and removed request for Manishearth and robertbastian July 23, 2024 17:54
@sffc sffc merged commit 9ec6b6b into unicode-org:main Jul 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants