Add docs explaining Ord on Locale #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Jul 25, 2024
robertbastian
approved these changes
Jul 25, 2024
| /// At the moment parsing normalizes a well-formed language identifier converting | ||
| /// `_` separators to `-` and adjusting casing to conform to the Unicode standard. | ||
| /// | ||
| /// Any bogus subtags will cause the parsing to fail with an error. |
There was a problem hiding this comment.
nit: mention LocaleCanonicalizer that does the other two things
There was a problem hiding this comment.
good idea; this is pre-existing content; will make it a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1215 and #5295
CC @JosiahBull