Replace mocks/stubs in tests with LSP

.github/workflows/main.yml

@@ -17,8 +17,8 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-latest
+          # - ubuntu-latest
           - windows-latest
         node:
-          - lts/erbium
+          # - lts/erbium
           - node

lib/index.js

@@ -66,21 +66,15 @@ function isValidUnistPoint(point) {
  */
 function unistLocationToLspRange(position) {
   if (position) {
-    if (isValidUnistPoint(position.start)) {
-      if (isValidUnistPoint(position.end)) {
-        return Range.create(
-          unistPointToLspPosition(position.start),
-          unistPointToLspPosition(position.end)
-        )
-      }
-
-      const start = unistPointToLspPosition(position.start)
-      return Range.create(start, start)
-    }
-
-    if (isValidUnistPoint(position.end)) {
-      const end = unistPointToLspPosition(position.end)
-      return Range.create(end, end)
+    const end = isValidUnistPoint(position.end)
+      ? unistPointToLspPosition(position.end)
+      : undefined
+    const start = isValidUnistPoint(position.start)
+      ? unistPointToLspPosition(position.start)
+      : end
+
+    if (start) {
+      return Range.create(start, end || start)
     }
   }
 
@@ -96,7 +90,7 @@ function unistLocationToLspRange(position) {
 function vfileMessageToDiagnostic(message) {
   const diagnostic = Diagnostic.create(
     unistLocationToLspRange(message.position),
-    message.reason,
+    String(message.stack || message.reason),
     message.fatal === true
       ? DiagnosticSeverity.Error
       : message.fatal === false
@@ -175,7 +169,7 @@ export function configureUnifiedLanguageServer(
           streamError: new PassThrough(),
           streamOut: new PassThrough()
         },
-        (error, code, context) => {
+        (error, _, context) => {
           // An error never occur and can’t be reproduced. Thus us ab internal
           // error in unified-engine. If a plugin throws, it’s reported as a
           // vfile message.
@@ -185,7 +179,7 @@ export function configureUnifiedLanguageServer(
           } else {
             resolve((context && context.files) || [])
           }
-          /* c8 ignore end */
+          /* c8 ignore stop */
         }
       )
     })
@@ -227,8 +221,12 @@ export function configureUnifiedLanguageServer(
     }
   }))
 
-  connection.onDocumentFormatting(async ({textDocument: {uri}}) => {
+  connection.onDocumentFormatting(async (event) => {
+    const {uri} = event.textDocument
     const document = documents.get(uri)
+
+    // `vscode-languageserver` crashes for commands to format unopen documents.
+    /* c8 ignore next 3 */
     if (!document) {
       return
     }
@@ -243,13 +241,16 @@ export function configureUnifiedLanguageServer(
     const start = Position.create(0, 0)
     const end = document.positionAt(text.length)
 
+    // V8 coverage bug on Dubnium (Node 12).
+    /* c8 ignore next 2 */
     return [TextEdit.replace(Range.create(start, end), result)]
   })
 
   documents.onDidChangeContent((event) => {
     checkDocuments(event.document)
   })
 
+  // Send empty diagnostics for closed files.
   documents.onDidClose((event) => {
     const {uri, version} = event.document
     connection.sendDiagnostics({
@@ -259,15 +260,20 @@ export function configureUnifiedLanguageServer(
     })
   })
 
+  // Check everything again if something changes.
   connection.onDidChangeWatchedFiles(() => {
     checkDocuments(...documents.all())
   })
 
   connection.onCodeAction((event) => {
+    const {uri} = event.textDocument
     /** @type {CodeAction[]} */
     const codeActions = []
 
-    const document = documents.get(event.textDocument.uri)
+    const document = documents.get(uri)
+
+    // `vscode-languageserver` crashes for commands to act on unopen documents.
+    /* c8 ignore next 3 */
     if (!document) {
       return
     }

package.json

@@ -42,13 +42,12 @@
     "vscode-languageserver-textdocument": "^1.0.0"
   },
   "devDependencies": {
-    "@types/sinon": "^10.0.0",
     "@types/tape": "^4.0.0",
     "c8": "^7.0.0",
+    "execa": "^6.0.0",
     "prettier": "^2.0.0",
     "remark-cli": "^10.0.0",
     "remark-preset-wooorm": "^9.0.0",
-    "sinon": "^12.0.0",
     "tape": "^5.0.0",
     "type-coverage": "^2.0.0",
     "typescript": "^4.0.0",
@@ -59,7 +58,7 @@
     "build": "rimraf \"lib/**/*.d.ts\" \"test/**/*.d.ts\" \"*.d.ts\" && tsc && type-coverage",
     "format": "remark . -qfo && prettier . -w --loglevel warn && xo --fix",
     "test-api": "node --unhandled-rejections=strict --conditions development test/index.js",
-    "test-coverage": "c8 --check-coverage --branches 100 --functions 100 --lines 100 --statements 100 --reporter lcov npm run test-api",
+    "test-coverage": "c8 --check-coverage --100 --reporter lcov npm run test-api",
     "test": "npm run build && npm run format && npm run test-coverage"
   },
   "prettier": {