Added instructions for root Update using-the-app-catalog.mdx #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oran C <[email protected]>
StefanJum
requested changes
Sep 28, 2024
There was a problem hiding this comment.
Thanks @wisehackermonkey. Besides the comments, use your full name for the author, committer and sign-off fields.
Before committing, do git config --global user.name and user.email. Right now the committer shows up as: Commit: GitHub <[email protected]>
| @@ -248,12 +248,18 @@ If, instead of port mapping, you want to use bridge networking, follow the steps | |||
|
|
|||
| ```bash | |||
| kraft net create -n 172.44.0.1/24 virbr0 | |||
| or | |||
| sudo kraft net create -n 172.44.0.1/24 virbr0 | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
Remove the empty line
| ``` | ||
|
|
||
| 1. Run as `root` (prefix with `sudo` if required): | ||
|
|
||
| ```bash | ||
| kraft run --network virbr0 . | ||
| or |
| ``` | ||
|
|
||
| 1. Run as `root` (prefix with `sudo` if required): | ||
|
|
||
| ```bash | ||
| kraft run --network virbr0 . | ||
| or | ||
| sudo kraft run --network virbr0 . | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a new user this was a bit confusing.
this make the instructions a bit more clear