fix(yamlmerger): Update RecursiveMerge to support ScalarNode kind
#1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
changed the title
nderjung
changed the title
RecursiveMerge to support ScalarNode kind
MdSahil-oss
force-pushed
the
refactor-lib-add
branch
from
b656e26
to
6cb224d
Compare
Signed-off-by: MdSahil-oss <[email protected]>
MdSahil-oss
force-pushed
the
refactor-lib-add
branch
from
6cb224d
to
c7927d3
Compare
|
I have no memory of this What I can guarantee is that it did fix something, so careful |
|
@LucaSeri I will assign you to further investigate this PR The change makes sense, but I can't remember if it breaks something It was something related to the writing of the (note: remember to try this on latest staging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
updates RecursiveMerge() for ScalarNode kind.
Currently on adding diffrent version of a pre-existing library in the project directory using cmd
kraft lib add lib_name:versionKraftfile doesn't get updated for the new version as expected.But after merging this PR, Kraftkit will be able to update the project
kraftfilefor the new version of the already existing library.