Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove the "build" workflow #409

Merged

Conversation

nderjung
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Thanks to the introduction of our e2e tests in #392, the build workflow has become redundant. It previously served as an e2e test by building and running the command kraft version which in itself is tested more extensively.

Thanks to the introduction of our e2e tests in unikraft#392, the build workflow
has become redundant.  It previously served as an e2e test by building
and running the command `kraft version` which in itself is tested more
extensively.

Signed-off-by: Alexander Jung <[email protected]>
@nderjung nderjung added kind/maintenance Issue or PR is general repository maintenance area/.github Issue or PR related to GitHub metadata area/.github/workflows Issue or PR related to GitHub Actions workflows labels Apr 25, 2023
Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Antoine Cotten [email protected]

@antoineco antoineco merged commit e68aa34 into unikraft:staging Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/.github/workflows Issue or PR related to GitHub Actions workflows area/.github Issue or PR related to GitHub metadata kind/maintenance Issue or PR is general repository maintenance
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

2 participants