Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnZip static PIE build #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add UnZip static PIE build #71

wants to merge 1 commit into from

Conversation

anindyasen
Copy link

#31

  1. Added zip application as a static-pie build
  2. A build.sh script is created to download, extract, patch and compile the application.
  3. rootfs, filesystem to store file in unikernel.
  4. Patch has the changes required in zip application to build it as static-pie.

StefanJum
StefanJum requested changes Oct 15, 2022
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you.
Please see the comments and also sign off your commit.

unzip/README.md Outdated Show resolved Hide resolved
unzip/README.md Outdated Show resolved Hide resolved
unzip/README.md Outdated Show resolved Hide resolved
unzip/build.sh Outdated Show resolved Hide resolved
unzip/build.sh Show resolved Hide resolved
StefanJum
StefanJum requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few more comments.

unzip/README.md Outdated Show resolved Hide resolved
unzip/README.md Outdated Show resolved Hide resolved
StefanJum
StefanJum requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anindyasen, few more comments, I will approve the pr after you address them.

unzip/README.md Outdated Show resolved Hide resolved
unzip/README.md Outdated Show resolved Hide resolved
unzip/README.md Outdated Show resolved Hide resolved
@StefanJum
Copy link
Member

All looks good now, but please remove the Co-authored-by: Jumarea Stefan <[email protected]> line from the commit message.

@anindyasen
Add UnZip static PIE build
6bbbe29 
Signed-off-by: anindya_sen <[email protected]>
StefanJum
StefanJum approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thank you @anindyasen.

Reviewed-by: Stefan Jumarea [email protected]

@anindyasen anindyasen mentioned this pull request Oct 21, 2022
Open
@razvand razvand linked an issue Oct 23, 2022 that may be closed by this pull request
Add UnZip static PIE build #31
Open
@razvand razvand added enhancement New feature or request kind/hackathon Hackathon challenge labels Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanJum StefanJum StefanJum approved these changes

Assignees

@razvand razvand

Labels
enhancement New feature or request kind/hackathon Hackathon challenge
Projects
(Binary) Application Compatibility
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UnZip static PIE build
3 participants
@anindyasen @StefanJum @razvand