Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP static PIE ELF build #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add PHP static PIE ELF build #78

wants to merge 1 commit into from

Conversation

gabryon99
Copy link

No description provided.

@MathVerg MathVerg mentioned this pull request Oct 23, 2022
Closed
@MathVerg
Copy link

When trying to run it we encountered this issue : unikraft/unikraft#611

razvand
razvand requested changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gabryon99 , see my comments.

php/.gitignore Outdated
@@ -0,0 +1 @@
/php-*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing newline

php/README.md
* libxml2 development files
* libsqlite3 development files

On Ubuntu, you can install these using:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On Ubuntu, you can install these using:
On Ubuntu, you can install these using:

php/README.md Outdated

The scripts downloads, unpack, patches and build the `php` static PIE ELF file.

## Running
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Running
## Run

php/README.md
```
./php helloworld.php
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

php/helloworld.php Outdated
@@ -0,0 +1 @@
<? echo "Hello world!\n" ?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing new line.

@razvand razvand linked an issue Oct 23, 2022 that may be closed by this pull request
Add PHP static PIE build #19
Open
@razvand razvand added enhancement New feature or request kind/hackathon Hackathon challenge labels Oct 23, 2022
@razvand razvand self-assigned this Oct 23, 2022
@razvand
Copy link
Collaborator

razvand commented Oct 23, 2022

50 hackathon points awarded

@AlessandroGrassi99 @albertoZurini
@mrBymax @gabryon99
Add PHP static PIE ELF build
faac9ec 
Signed-off-by: Mathéo Vergnolle <[email protected]>
Signed-off-by: Gabriele Pappalardo <[email protected]>
Co-authored-by: Alessandro Grassi <[email protected]>
Co-authored-by: Alberto Zurini <[email protected]>
Co-authored-by: Federico Bertossi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand requested changes

Assignees

@razvand razvand

Labels
enhancement New feature or request kind/hackathon Hackathon challenge
Projects
(Binary) Application Compatibility
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PHP static PIE build
3 participants
@gabryon99 @MathVerg @razvand