Add iputils static PIE build #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouk
force-pushed
the
master
branch
2 times, most recently
from
e30b82c
to
11f2e97
Compare
Signed-off-by: Groute <[email protected]>
Signed-off-by: Konstantinos Koukopoulos <[email protected]>
Signed-off-by: Groute <[email protected]>
Signed-off-by: Groute <[email protected]>
Signed-off-by: Konstantinos Koukopoulos <[email protected]>
Signed-off-by: Groute <[email protected]>
Signed-off-by: Konstantinos Koukopoulos <[email protected]>
Signed-off-by: Konstantinos Koukopoulos <[email protected]>
razvand
requested changes
Apr 16, 2023
Comment on lines
+7
to
+8
| Make sure the following packages are installed: | ||
| * gcc >= 8 (required for the `-static-pie` linking option) |
There was a problem hiding this comment.
Suggested change
| Make sure the following packages are installed: | |
| * gcc >= 8 (required for the `-static-pie` linking option) | |
| Make sure the following packages are installed: | |
| * gcc >= 8 (required for the `-static-pie` linking option) |
|
|
||
| For Debian, run the command below to install all requirements: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Suggested change
| ```bash | |
| ```console |
| The static PIE ELF file are located in the current directory. | ||
| If you want to rebuild them, run: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Suggested change
| ```bash | |
| ```console |
| The resulting binaries can be used as is. | ||
| For example, you can ping an address by issuing the command: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Suggested change
| ```bash | |
| ```console |
Comment on lines
+60
to
+62
| 1. When running in KVM with LWIP you can't use RAW sockets because they're not | ||
| available by default. See this for more information: | ||
| https://github.com/unikraft/lib-lwip/pull/2 |
There was a problem hiding this comment.
Suggested change
| 1. When running in KVM with LWIP you can't use RAW sockets because they're not | |
| available by default. See this for more information: | |
| https://github.com/unikraft/lib-lwip/pull/2 | |
| 1. When running in KVM with LWIP you can't use RAW sockets because they're not available by default. | |
| See [this](https://github.com/unikraft/lib-lwip/pull/2) for more information. |
Comment on lines
+64
to
+65
| 2. There is a bug in LWIP where normal sockets (not RAW) that use ICMP protocol | ||
| are sent using UDP protocol instead. See https://github.com/unikraft/lib-lwip/issues/32 |
There was a problem hiding this comment.
Suggested change
| 2. There is a bug in LWIP where normal sockets (not RAW) that use ICMP protocol | |
| are sent using UDP protocol instead. See https://github.com/unikraft/lib-lwip/issues/32 | |
| 2. There is a bug in LWIP where normal sockets (not RAW) that use ICMP protocol are sent using UDP protocol instead. | |
| See [issue `#32`](https://github.com/unikraft/lib-lwip/issues/32). |
| Make sure the following packages are installed: | ||
| * gcc >= 8 (required for the `-static-pie` linking option) | ||
| * autotools | ||
| * meson |
There was a problem hiding this comment.
Suggested change
| * meson | |
| * meson | |
| * xsltproc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes ping, arping, etc.
Fixes: #86