Allow for filtering of output. #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Command output may be filtered by `|` followed by whitespace and a regular expression (or a simple string). - The regular expression is applied to each line of output, and only lines that match are displayed. - The expression may be negated by using `|!` instead of `|`. - Substitution is not supported.
terjekv
force-pushed
the
filter_results
branch
from
6ed8d77
to
20023ac
Compare
- re.Pattern requires python 3.7+ as a bare minumum.
oyvindkolbu
reviewed
Sep 1, 2023
|
|
||
| if filter_str.startswith("!"): | ||
| negate = True | ||
| filter_str = filter_str[1:].strip() |
There was a problem hiding this comment.
This strip is superflous as it has already been stripped. Just need the [1:].
|
You are mixing functial and formatting changes. Makes review very hard. |
|
Yeah. Sadly my editor setup is strict with PEPs. I'll try to review the settings for the project for every copy of the repo I work on. In general though I'm tempted to do a pure formatting PR towards black and isort, and adding them to a lint job. |
terjekv
added a commit
to terjekv/mreg-cli
that referenced
this pull request
Nov 12, 2023
- Command output may be filtered by `|` followed by whitespace and a regular expression (or a simple string). - The regular expression is applied to each line of output, and only lines that match are displayed. - The expression may be negated by using `|!` instead of `|`. - Substitution is not supported. Examples: - `network list_used_addresses 172.16.20.0 | bl23-.*mu2[17]` will output only lines matching the regular expression. - `network list_used_addresses 172.16.20.0 |! mu2[17]` will output only lines *not* matching the regular expression. This applies all commands that output to the console, but it does *not* apply to errors, warnings, or informational messages. This allows filters to be used without concern for missing important information. This is a cleaner Singleton-based implementation of unioslo#171.
|
Superseded by a much better implementation in #174. |
terjekv
added a commit
to terjekv/mreg-cli
that referenced
this pull request
Nov 23, 2023
- Command output may be filtered by `|` followed by whitespace and a regular expression (or a simple string). - The regular expression is applied to each line of output, and only lines that match are displayed. - The expression may be negated by using `|!` instead of `|`. - Substitution is not supported. Examples: - `network list_used_addresses 172.16.20.0 | bl23-.*mu2[17]` will output only lines matching the regular expression. - `network list_used_addresses 172.16.20.0 |! mu2[17]` will output only lines *not* matching the regular expression. This applies all commands that output to the console, but it does *not* apply to errors, warnings, or informational messages. This allows filters to be used without concern for missing important information. This is a cleaner Singleton-based implementation of unioslo#171.
terjekv
added a commit
that referenced
this pull request
Nov 24, 2023
* feat: Allow for filtering of output - Command output may be filtered by `|` followed by whitespace and a regular expression (or a simple string). - The regular expression is applied to each line of output, and only lines that match are displayed. - The expression may be negated by using `|!` instead of `|`. - Substitution is not supported. Examples: - `network list_used_addresses 172.16.20.0 | bl23-.*mu2[17]` will output only lines matching the regular expression. - `network list_used_addresses 172.16.20.0 |! mu2[17]` will output only lines *not* matching the regular expression. This applies all commands that output to the console, but it does *not* apply to errors, warnings, or informational messages. This allows filters to be used without concern for missing important information. This is a cleaner Singleton-based implementation of #171.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|followed by whitespace and a regular expression (or a simple string).|!instead of|.Examples:
network list_used_addresses 172.16.20.0 | bl23-.*mu2[17]will output only lines matching the regular expression.network list_used_addresses 172.16.20.0 |! mu2[17]will output only lines not matching the regular expression.This applies all commands that output to the console, but it does not apply to errors, warnings, or informational messages. This allows filters to be used without concern for missing important information.