Add prompt string interpolation #311
Conversation
README.md
Outdated
|
|
||
| #### Disabling the prompt text | ||
|
|
||
| The prompt text can be disabled by setting it to an empty string in either the config or as a command line argument: |
There was a problem hiding this comment.
What does "disabled" mean in this context? ">" or ""?
There was a problem hiding this comment.
It means >, which is why I specified "prompt text". If you have any ideas how to make it clearer, then I'll change it.
There was a problem hiding this comment.
This was changed to "prompt prefix text", which isn't great, but it should remove any ambiguity when combined with the example showing the result.
|
I think this is ready now? There are some basic unit test for IPv4 and IPv6, but they are not comprehensive at all. Should be fine though. |
|
One last thing we should consider taking a look at is moving the prompt configuration section in the README somewhere else, because it takes up a lot of space very early on for such a trivial feature. Edit: I hid it in a collapsible section that defaults to being closed. |
Adds string interpolation support for the CLI prompt. In order to test this, the
get_prompt_message()function has been extracted frommain().Furthermore, the parsing of command-line config arguments is now moved into the config itself. CLI args are now accessed through
MregCliConfig.get()instead of viavars(args).