Make NETWORK arg consistent in commands
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjekv
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can specify a network with its network id in
network info(i.e. 192.168.0.0 can be used to find the network192.168.0.0/24), it makes sense to make this behavior consistent across allnetworkcommands. That way,network info 192.168.0.0andnetwork list_unused_addresses 192.168.0.0both work by finding the network associated with the address192.168.0.0.A side effect of this new approach, which uses
Network.get_by_any_means_or_raise(), is that these commands can also find networks using their internal IDs.