-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 4 support: Option 5, migrating to django-filter (v2) #492
Merged
Commits on Dec 5, 2023
-
Fixes unioslo#487 by implementing option 5 in the issue.
Supports: python3.7+, django 3.2+. Tests included for this range. Breaking changes: None This implementation uses django-filter as intended. It sets a default filter backend and uses standard filter_class models where possible. Exceptions take place in the following views: HostList. Relies on manipulating the queryset, and said manipulation is also used in the filter-less HostDetail. *Zone*List. The abstraction model for these views is based around propagating a filterset into the parent class. Concerns: This patch creates explicit mapping filters for JSONField and CIDRField. It is unclear how well-tested these are.
Configuration menu - View commit details
-
Copy full SHA for 46a17e6 - Browse repository at this point
Copy the full SHA 46a17e6View commit details -
Update pyproject.toml fix package building (for tox)
- Required as we intriduced the toml file for ruff. - Sets some default keys. - Make tox.ini use the lint and coverage environments. - Make tox runs that use pythons and django show versions for both.
Configuration menu - View commit details
-
Copy full SHA for aa9c83d - Browse repository at this point
Copy the full SHA aa9c83dView commit details -
- Uses filterset_class correctly. - Applies the filter via MregMixin. - Test basic filtering in hostgroups.
Configuration menu - View commit details
-
Copy full SHA for 3d2a97f - Browse repository at this point
Copy the full SHA 3d2a97fView commit details -
- Requires manual lookup declarations. - See unioslo#489 (comment)
Configuration menu - View commit details
-
Copy full SHA for c3a469e - Browse repository at this point
Copy the full SHA c3a469eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6ed647 - Browse repository at this point
Copy the full SHA e6ed647View commit details -
Configuration menu - View commit details
-
Copy full SHA for 454a07b - Browse repository at this point
Copy the full SHA 454a07bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd4fe41 - Browse repository at this point
Copy the full SHA bd4fe41View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 630faf8 - Browse repository at this point
Copy the full SHA 630faf8View commit details
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34d5032 - Browse repository at this point
Copy the full SHA 34d5032View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.