Reimplement the CLI in TypeScript #172
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port the uniprot command
Add linting, testing and type checks
Port peptfilter to typescript
Co-authored-by: Pieter Verschaffelt <[email protected]>
Port prot2pept to typescript
implement xml and json formatters
Add fasta support
Implement all unipept subcommands and tests
Finalize implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ruby cli client became hard to maintain. The script for publishing new versions breaks every release and there were some problems getting this to work on windows. In addition, the use of native code required a compilation step during installation which often caused issues. The goal is to develop a drop-in replacement.
Breaking changes
These are not really breaking changes since they are also broken in the current ruby tool.
--meganizeflag of the pept2prot command wasn't ported since this relied on fields no longer present in the database.