Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to search only tryptic matches #27

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Conversation

SimonVandeVyver
Copy link
Contributor

@SimonVandeVyver SimonVandeVyver commented Sep 13, 2024

this PR adds functionality to the index to match only tryptic peptides.
After searching the matches in the suffix array, we check for each match if trypsin could cut the queried peptide from the corresponding protein.

@SimonVandeVyver SimonVandeVyver self-assigned this Sep 13, 2024
Copy link
Member

@pverscha pverscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked and gone through the code and to me it looks ok. I do need to verify it with a few more in-depth tests to be 100% sure, but @tibvdm you can also already take a look at the code in this PR.

@SimonVandeVyver SimonVandeVyver marked this pull request as ready for review September 19, 2024 08:04
Copy link
Member

@pverscha pverscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked this PR in detail, ran a lot of data validation tests and all is ok!

@pverscha pverscha changed the title add functionality to search only tryptic matches Add functionality to search only tryptic matches Sep 19, 2024
@pverscha pverscha merged commit 26dd5e5 into develop Sep 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants