Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring - protected #84

Closed
wants to merge 2 commits into from
Closed

refactoring - protected #84

wants to merge 2 commits into from

Conversation

fabienjuif
Copy link
Member

@fabienjuif fabienjuif commented Nov 3, 2017 •
edited
Loading

fixes #83 - Related issue
fixes #34 - Documentation
fixes #32 - Documentation
fixes #81 - Hot reload in examples

Before merge

  • remove the first commit (with a git rebase -i master)
  • remove commits descriptions (with a git rebase -i master), take care to set the right author with git commit --amend --author
  • take care of authors not to be deleted after rebase, if needed, to reset use something like : git commit --amend --author 'Fabien JUIF <[email protected]>'

@fabienjuif fabienjuif changed the title 📝 refactoring (readme) refactoring - protected Nov 3, 2017
@frinyvonnick
🔧 Add lerna to handle multiple package architecture
958b1ec 
* 🎨 Move sources into packages folder

* 🚨 Link packages and fix linting

* 🔥 Remove examples site and fresh install one with create-react-app

* 🔨 Remove empty line

* 💚 Fix ci script

* 🔥 Remove default content

* 🔧 Remove non-existent option on lerna bootstrap

* 🔧 Add start script for examples in root package.json

* 🔨 Set right package and version in hoc-react-loader-examples

* 🔨 Remove tab characters

* 👌 Use scope instead of ignore option

* 🎨 Move LICENSE and README.md to root level
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.462% when pulling 958b1ec on refactoring-protected into b3f2b3a on master.

@fabienjuif
Copy link
Member Author

@frinyvonnick can you take care of removing comment from a squash commit to avoid this please ?
image

@fabienjuif
Copy link
Member Author

I will remove this description when this PR will be ready to rebase merge

@frinyvonnick
Copy link
Collaborator

Sure i can 👍

@fabienjuif
Copy link
Member Author

fabienjuif commented Nov 23, 2017 •
edited
Loading

@frinyvonnick FYI
I am currently using lerna into my client project.
And I am right in this issue: lerna/lerna#1114

So I move back to npm for that client ;)

edit:

@frinyvonnick
Copy link
Collaborator

Maybe we can close this PR ?

@fabienjuif
Copy link
Member Author

Yeah, sorry about this :(

@fabienjuif fabienjuif closed this Oct 11, 2018
@fabienjuif fabienjuif deleted the refactoring-protected branch October 17, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@fabienjuif @coveralls @frinyvonnick