Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plkl param prediction with multi_models=False #2545

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Sep 27, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Summary

  • Fixes a bug when predicting with predict_likelihood_parameters=True, n > 1 and a RegressionModel with multi_models=False that uses a likelihood. The prediction now works without raising an exception.

Other Information

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (e9daf67) to head (f5511f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         139      139           
  Lines       14855    14844   -11     
=======================================
- Hits        13943    13934    -9     
+ Misses        912      910    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 6c3571d into master Sep 28, 2024
9 checks passed
@dennisbader dennisbader deleted the fix/regr_non_multi_model_likelihood_params branch September 28, 2024 10:51
eschibli pushed a commit to eschibli/darts that referenced this pull request Oct 8, 2024
* fix plkl param prediction with multi_models=False

* update changelog.md

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant