-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs (adapted from Qulacs) #14
Conversation
LGTM. Note that this and #13 are basically duplicate, modulo the correct explanations in simulator.rst and toml file in this one, and the readme edits I made to include the invisible markers to have the installation and support menu display, see here. Either way is fine for me. Note that automodapi in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a github workflow step to build the docs.
doc/_static/puzzle_qulacs.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated after #15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WrathfulSpatula looks good, just remember to add the markers to the main README.rst
file like done in #13.
Note that the functions docstrings are not listed in the API doc, but the plugin is private. In any case, in another issue, we could at least format the QrackDevice class docstring, so that it shows up on the api page.
@WrathfulSpatula any idea why tests are failing? Should they pass? |
@nathanshammah They're not expected to pass until Catalyst v0.7 is released. I attempted to replace the test runner dependency with building from source, but Catalyst takes entirely too long to compile: the tests don't even complete, in that case. The tests work locally with v0.7, and they will pass once it's officially released to PyPi. |
@nathanshammah, actually, we can't. While we can change the single top-level comment, in order to display docs for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Shall we open a separate issue to address @cosenal point on adding a "github workflow step to build the docs"? If it's easy to grab it from qulacs, let's do it in this PR, otherwise I'd move forward with merging this. We should also host the docs on RTD (other issue).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nathanshammah This is already fully adapted and working from the Qulacs repository. Really, users don't specifically need anymore information than this. (Does this look alright?)