Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reallocation after free #19

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

WrathfulSpatula
Copy link
Collaborator

This allows a Qrack device to reallocate (up to the original wires size requested in the constructor) after releasing qubits.

Copy link

@cosenal cosenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the disclaimer that I am not familiar with the test suite here, should reallocation be covered by a test?

@WrathfulSpatula
Copy link
Collaborator Author

WrathfulSpatula commented Jul 12, 2024

With the disclaimer that I am not familiar with the test suite here, should reallocation be covered by a test?

Yes, but the tests are currently breaking for other reasons. The simplest possible test is simply recreating your example (without mitigation). I'll add the test, but I'm not sure that we can run it on CI/CD, for now.

@WrathfulSpatula WrathfulSpatula merged commit d620c3f into master Jul 12, 2024
1 check passed
@WrathfulSpatula WrathfulSpatula deleted the release_realloc_debug branch July 12, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants