Samples and Counts output debugging #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprusso
approved these changes
Jun 6, 2024
| @@ -2,4 +2,4 @@ pennylane>=0.32 | |||
| pennylane-catalyst>=0.6 | |||
| pyqrack>=0.13.0 | |||
| numpy~=1.16 | |||
| scikit-build | |||
| scikit-build>=0.1.0 | |||
There was a problem hiding this comment.
Do we need to specify these requirements in both the setup and requirements? I believe there's a way to define them in one spot and then use them in both.
There was a problem hiding this comment.
There is, but many projects do it either way. For now, I prefer this to piping in the requirements.txt.
There was a problem hiding this comment.
I looked into it a bit, for due diligence: setup.py needs installation dependencies; requirements.txt needs development build dependencies. Except in the case these two dependency lists are identical, perhaps they should be kept distinct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the conversion from Qrack integer bit string sample histograms to the expected output formats of PennyLane Catalyst
Samples()andCounts().