fix: ensure Cloudflare webcrypto.getRandomBytes is bound to the correct this object #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct this object It appears that this is the only function in the webcrypto exports list that needs to be bound to its original object. Note that it must be bound to the `webcrypto` object even though workerd also exports it on the `crypto` namespace directly.
petebacondarwin
force-pushed
the
fix-webcrypto-bindings-2
branch
from
db2a475
to
1e87097
Compare
petebacondarwin
commented
Sep 16, 2024
Comment on lines
+109
to
+111
| export const getRandomValues = workerdCrypto.getRandomValues.bind( | ||
| workerdCrypto.webcrypto, | ||
| ); |
There was a problem hiding this comment.
This is the correct fix.
We need to ensure that every export of this function is correctly bound.
Not just the one from webcrypto.
petebacondarwin
changed the title
pi0
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that this is the only function in the webcrypto exports list that
needs to be bound to its original object.
Note that it must be bound to the
webcryptoobject even though workerd alsoexports it on the
cryptonamespace directly.