Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add optional USE_EXTERNAL_LIBDEFLATE #83

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jan 16, 2024

When setting USE_EXTERNAL_LIBDEFLATE=1 as a make(1) argument a system version will be used and otherwise it will use the vendored libdeflate.

This was tested using libdeflate-1.19 that was recently added to Gentoo (gentoo/gentoo@bae8948).

There are also a few trivial commits to improve the Makefile.

The first build rule is the default rule.
When using = instead of := the variable is set when its used and not
when its set. This prvents pkg-config from being run even when the value
of the variable is being set by the user as a make(1) argument.
When setting USE_EXTERNAL_LIBDEFLATE=1 as a make(1) argument a system
version will be used and otherwise it will use the vendored libdeflate.
@orbea
Copy link
Contributor Author

orbea commented Jan 21, 2024

@unknownbrackets When you have time I would really appreciate if you can review this PR.

Copy link
Owner

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, haven't had a lot of time of late. Thanks, this looks reasonable.

-[Unknown]

@unknownbrackets unknownbrackets merged commit dd369e3 into unknownbrackets:master Jan 26, 2024
3 checks passed
@orbea orbea deleted the build branch January 26, 2024 14:45
@orbea
Copy link
Contributor Author

orbea commented Jan 26, 2024

@unknownbrackets Thanks! Any chance you could tag a new patch release? It would be helpful to get the build fixes into distros and its a bit much to backport.

orbea added a commit to orbea/gentoo that referenced this pull request Jan 27, 2024
Upstream now supports an external libdeflate.

Upstream-PR: unknownbrackets/maxcso#83
Upstream-Commit: unknownbrackets/maxcso@4949344
Signed-off-by: orbea <[email protected]>
orbea added a commit to orbea/gentoo that referenced this pull request Jan 27, 2024
Upstream now supports an external libdeflate.

Upstream-PR: unknownbrackets/maxcso#83
Upstream-Commit: unknownbrackets/maxcso@4949344
Signed-off-by: orbea <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 23, 2024
Upstream now supports an external libdeflate.

Upstream-PR: unknownbrackets/maxcso#83
Upstream-Commit: unknownbrackets/maxcso@4949344
Signed-off-by: orbea <[email protected]>
Closes: #35035
Signed-off-by: Viorel Munteanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants