Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support proxies #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature: support proxies #25

wants to merge 1 commit into from

Conversation

leepowelldev
Copy link

Sadly this package currently fails to work for us behind a corporate proxy as http-https fails to pick up proxy settings from environment variables on the OS. The request package does this very well - so this is a simple swap out from http-https to request. Interface remains unchanged.

@ghost
Copy link

ghost commented Sep 23, 2020

DeepCode's analysis on #f0926c found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@unlight
Copy link
Owner

unlight commented Sep 23, 2020

I think we need to choose another replacement, request is deprecated.

@leepowelldev
Copy link
Author

leepowelldev commented Sep 23, 2020 via email

@unlight
Copy link
Owner

unlight commented Sep 23, 2020

@leepowelldev
Copy link
Author

Thanks. I was thinking of looking at axios. It’s fairly small and is well maintained.

Juice10 added a commit to recordonce/postcss-import-url that referenced this pull request May 6, 2023
…axios.

- Removes deprecated url apis
- Fixes unlight#25
- And Axios is supported in both node.js and browser.
Juice10 added a commit to recordonce/postcss-import-url that referenced this pull request May 6, 2023
…axios.

- Removes deprecated url apis
- Fixes unlight#25
- And Axios is supported in both node.js and browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants