-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/mama/docs-Figma-UI-Import-update #138
base: master
Are you sure you want to change the base?
Conversation
Matt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
@mtmattei some of the comments I've left are based on personal style. Feel free to simply close them if you disagree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtmattei I am a bit confused about the screenshots updates here
They are not following the figma file or the default material styles colors
We will sync on this tomorrow please
Not related to Matthew changes, but the following links are broken when running docfx:
They should be changed to follow this type of snippet: workshops/simple-calc/modules/MVUX-CSharp/01-Build your first Project/README.md Lines 30 to 34 in d861975
|
Yes your right, we can ignore those screenshots but initially when I opened the SimpleCalc from the community file, that is what the Calculator looked like. I reopened it and it is different now.. |
Co-authored-by: Shimmy <[email protected]>
Co-authored-by: Shimmy <[email protected]>
Co-authored-by: Shimmy <[email protected]>
Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
Co-authored-by: Shimmy <[email protected]>
Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
…a.md Co-authored-by: Shimmy <[email protected]>
Check what the location of the files is after being rendered (browse the exported files by removing the |
simple-calc/modules/Resources/CSharp/Figma/Import-UI-from-Figma.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Bilogan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtmattei @agneszitte need to resolve the discussions on this PR
Description (*)
Fixed Issues (if necessary)
Screenshots (if necessary)
Contribution checklist (*)