Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mama/docs-Figma-UI-Import-update #138

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

mtmattei
Copy link

@mtmattei mtmattei commented Nov 9, 2023

Description (*)

Fixed Issues (if necessary)

Screenshots (if necessary)

Contribution checklist (*)

  • I have read the Contributing Guidelines
  • Commits have been made with meaningful commit messages
  • All automated tests have passed successfully

@mtmattei mtmattei requested a review from agneszitte November 9, 2023 20:40
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ nickrandolph
✅ mtmattei
❌ Matt


Matt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@weitzhandler
Copy link
Member

weitzhandler commented Nov 10, 2023

@mtmattei some of the comments I've left are based on personal style. Feel free to simply close them if you disagree.

Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtmattei I am a bit confused about the screenshots updates here
They are not following the figma file or the default material styles colors
We will sync on this tomorrow please
image
image

@eriklimakc
Copy link
Contributor

Not related to Matthew changes, but the following links are broken when running docfx:

They should be changed to follow this type of snippet:

<details>
<summary><i>Calculator.cs</i> code contents (collapsed for brevity)</summary>
[!code-csharp[Calculator.cs](../../../resources/Calculator.cs)]
</details>

cc @nickrandolph @agneszitte @weitzhandler @mtmattei

@mtmattei
Copy link
Author

@mtmattei I am a bit confused about the screenshots updates here They are not following the figma file or the default material styles colors We will sync on this tomorrow please image image

Yes your right, we can ignore those screenshots but initially when I opened the SimpleCalc from the community file, that is what the Calculator looked like. I reopened it and it is different now..

@weitzhandler
Copy link
Member

Not related to Matthew changes, but the following links are broken when running docfx:

Check what the location of the files is after being rendered (browse the exported files by removing the _site and the page), then make sure it points to the proper location.

Copy link
Collaborator

@nickrandolph nickrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtmattei @agneszitte need to resolve the discussions on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants