Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Slider): orientation=vertical support #734

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jankremlacek
Copy link
Contributor

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added styles for <Slider orienation="vertical" />.

The orientation property is not mentioned in the documentation, but radix-vue supports it, and the property is inherited. With this update, if someone uses the orientation="vertical", it will render the <Slider /> properly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Note: I did not update the documentation cause I do not know if you want to. If you want to add it to the docs, let me know.

@sadeghbarati
Copy link
Collaborator

@zernonia Related PR #739

Should we offer generic styles based on orientation?

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this addition seems straightforward and useful. LGTM!

@zernonia zernonia merged commit ff6d9d0 into unovue:dev Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants