add mclayton as author #56
untitakerAnnotations
22 warnings
|
manual check for common ascii range:
src/urls.rs#L17
warning: manual check for common ascii range
--> src/urls.rs:17:9
|
17 | if !matches!(first_char, b'a'..=b'z' | b'A'..=b'Z') {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_char.is_ascii_alphabetic()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
= note: `#[warn(clippy::manual_is_ascii_check)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/collector.rs#L97
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/collector.rs:97:54
|
97 | let mut href = BumpString::from_str_in(path, &arena);
| ^^^^^^ help: change this to: `arena`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unnecessary closure used to substitute value for `Option::None`:
src/collector.rs#L89
warning: unnecessary closure used to substitute value for `Option::None`
--> src/collector.rs:89:24
|
89 | let qs_start = used_link
| ________________________^
90 | | .href
91 | | .0
92 | | .find(&['?', '#'][..])
93 | | .unwrap_or_else(|| used_link.href.0.len());
| |______________----------------------------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(used_link.href.0.len())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/collector.rs#L85
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/collector.rs:85:29
|
85 | if is_external_link(&used_link.href.0.as_bytes()) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `used_link.href.0.as_bytes()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/collector.rs#L72
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/collector.rs:72:62
|
72 | LinkState::Undefined(links2) => links.extend(links2.into_iter()),
| ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `links2`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
manual check for common ascii range:
src/urls.rs#L17
warning: manual check for common ascii range
--> src/urls.rs:17:9
|
17 | if !matches!(first_char, b'a'..=b'z' | b'A'..=b'Z') {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_char.is_ascii_alphabetic()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
= note: `#[warn(clippy::manual_is_ascii_check)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/collector.rs#L97
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/collector.rs:97:54
|
97 | let mut href = BumpString::from_str_in(path, &arena);
| ^^^^^^ help: change this to: `arena`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unnecessary closure used to substitute value for `Option::None`:
src/collector.rs#L89
warning: unnecessary closure used to substitute value for `Option::None`
--> src/collector.rs:89:24
|
89 | let qs_start = used_link
| ________________________^
90 | | .href
91 | | .0
92 | | .find(&['?', '#'][..])
93 | | .unwrap_or_else(|| used_link.href.0.len());
| |______________----------------------------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(used_link.href.0.len())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/collector.rs#L85
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/collector.rs:85:29
|
85 | if is_external_link(&used_link.href.0.as_bytes()) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `used_link.href.0.as_bytes()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/collector.rs#L72
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/collector.rs:72:62
|
72 | LinkState::Undefined(links2) => links.extend(links2.into_iter()),
| ^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `links2`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/iter/traits/collect.rs:371:18
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
docker
The following actions uses node12 which is deprecated and will be forced to run on node16: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9, docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38, docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|