Update HyperLinkCell.cs #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made all the modifications based on the behavior of the Latest Excel under Windows: the cursor change only when the mouse is over the text. To achieve that: 1. I've changed the name of the property from IsPressed to IsOverLink. 2. I've removed OnStartEdit because you can still edit the cell even if the mouse is over the link. 3. I've remove the event OnMouseEnter and replaced them with OnMouseMove. OnMouseLeave is still there. 4. OnMouse mouse check if the mouse is over the text and change IsOverLink accordingly and manage the cursor 5. For each events, the default behavior is kept. Example: Even if the mouse is down over the text, you can still move outside the cell and select a range 6. In Excel, with the mouse down over the link, if you move the mouse before mouse up, the navigate process is stopped. Unfortunately, I couldn't reproduce since when the mouse is down, OnMouseMove isn't receiving any event. Not sure why. Same for OnMouseLeave, not sure it's useful.
|
@lamazze Thanks! Nice changes! Since it makes some behaviors doesn't compatible with the original hyperlink, I will make another change to implement your requirement. |
|
Issue #309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made all the modifications based on the behavior of the Latest Excel under Windows: the cursor changes only when the mouse is over the text.
To achieve that:
IsPressedtoIsOverLink.OnStartEditbecause you can still edit the cell even if the mouse is over the link.OnMouseEnterand replaced them withOnMouseMove.OnMouseLeaveis still there.OnMouseMovemouse check if the mouse is over the text and changeIsOverLinkaccordingly and manage the cursorOnMouseMoveisn't receiving any events. Not sure why. Same forOnMouseLeave, not sure it's useful.