Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): improve upsert (#13) #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AxelThevenot
Copy link
Contributor

@AxelThevenot AxelThevenot commented May 17, 2023

refactor(utils)!: improve upsert (#13)

Features
/

Fixes
- docs: table references must be fully qualified.
- bigfunctions: procedure inserts in logs only in bigfunctions projects. #87

Deprecations
/

Breaking Changes
- delta is changed to upsert mode. upsert function will be renamed in merge.

Issue #13


feat(utils)!: renamed upsert for merge (#13)

Features
- merge function is the renamed upsert function.

Fixes
/

Deprecations
/

Breaking Changes
- upsert does not exists anymore.

Issue #13 #87

@AxelThevenot AxelThevenot marked this pull request as draft May 17, 2023 21:28
@AxelThevenot
Copy link
Contributor Author

I let you choose if you want to keep the upsert function which will call the merge function in "upsert" mode.

I do not think the upsert function is really valuable as the merge handles everything :)

@AxelThevenot AxelThevenot marked this pull request as ready for review May 18, 2023 11:00
**Features**
/

**Fixes**
    - docs: table references must be fully qualified.
    - bigfunctions: procedure inserts in logs only in bigfunctions projects. unytics#87

**Deprecations**
/

**Breaking Changes**
    - `delta` is changed to `upsert` mode. `upsert` function will be renamed in `merge`.

Issue unytics#13 unytics#87
**Features**
    - `merge` function is the renamed `upsert` function.

**Fixes**
/

**Deprecations**
/

**Breaking Changes**
    - `upsert` does not exists anymore.

Issue unytics#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant