Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-commit to check styles #152

Merged
merged 14 commits into from
Oct 14, 2024
Merged

Use pre-commit to check styles #152

merged 14 commits into from
Oct 14, 2024

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jun 18, 2024

Overview

pre-commit is very useful to manage and run various linters.

https://pre-commit.com/

Changes

Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
@yu-iskw yu-iskw marked this pull request as ready for review June 18, 2024 07:08
This reverts commit 898e912.
Signed-off-by: Yu Ishikawa <[email protected]>
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 18, 2024

@unytics I don't want to bother you, but I want to get your thoughts on it.Thak you so much for the great project.

Copy link
Owner

@unytics unytics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR @yu and sorry for the delay.

I added a few comments.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
bigfun/cli.py Outdated Show resolved Hide resolved
bigfun/cli.py Outdated Show resolved Hide resolved
@unytics unytics merged commit 8fb1130 into unytics:main Oct 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants