#1160 add styling to popular tags #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
reviewed
Oct 8, 2022
_includes/scripts.html
Outdated
| <% _.each(popularTags, function(entry, key){ %> | ||
| <li><a><%-entry.name%></a> (<%-entry.frequency%>)</li> | ||
| <a title="Popular Tag: <%-entry.name%>" tabindex="0"><%-entry.name%> <span class="popular-tags__frequency">(<%-entry.frequency%>)</span></a> |
There was a problem hiding this comment.
🤔 Can we do these styling changes without losing the ul/li semantics of these elements?
shiftkey
added
the
has questions
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
shiftkey
removed
the
has questions
shiftkey
requested changes
Oct 21, 2022
… from div restructure)
|
Checking the latest changes to the pull request... 352 projects without issues ✅Everything should be good to merge! |
cweave
force-pushed
the
style-popular-tags
branch
from
255c99e
to
d6fad2b
Compare
|
@cweave Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1160 add styling to popular tags
Light mode, python hover/active state:
Dark mode, python hove/active state:
iPhone 12/13 screensize (375px wide):
popular-taglist to adivwith links. Addstitlesand tabbing order to the links for a11y.container-bordercolor to rbg value.container-border-altcolor for darkmode