-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for dark mode toggling via keyboard #3526
base: gh-pages
Are you sure you want to change the base?
Allow for dark mode toggling via keyboard #3526
Conversation
@06b How can one change dark mode from keyboard with this? Which buttons? |
@ritwik12 When the theme-selector button has keyboard focus a person can press either the space or enter key and it will toggle the styles. |
@06b apologies for the delay in reviewing this, but it seems like there are conflicts here which I'm not sure how to resolve. Are you able to take a look at this branch and get it back to a working state? |
👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under As you make changes to this pull request, I'll re-run these checks. |
@shiftkey Yeah, that didn't go as planned. If it's alright with you, I'll close this pull request and when I get sometime in the future I'll try again and ping you? |
9727d7a
to
e561d6e
Compare
@06b all good, I've taken a shot at rebasing and squishing the history. I'll drop some notes in here about what I did but hopefully this branch gets us into a good spot for validating the changes... |
|
Co-authored-by: Adrian D. Alvarez <[email protected]>
0bed74b
to
d0e75fc
Compare
The following changes were made:
[data-theme-preference]
attribute on the html element.