Styling update #964
Closed
Styling update #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filter 'tags' put in seperate div for styling - H1 text have had their cursors changed to 'default'
…eir prefered / learning language and dive in - Restyled the popular tags for consistancy - Removed the 'before' on popular tags as all it seemed to be doing was adding an empty space?
|
@shiftkey - can you look at this when you have time please? |
|
@AllanOcelot Thanks for your PR, can you add some screenshots or video of your work? It will be easy for us that way. |
|
Sure thing @ritwik12 , please find screenshots of the changes here: 👍 |
|
@AllanOcelot That's good, but I would like you to add more things to it. There's a lot to be improved. It will be good if we have a good design. |
shiftkey
reviewed
Jan 22, 2019
There was a problem hiding this comment.
The changes look reasonable, but there's a merge conflict with the Popular tags change in #1121 that need to be merged into this PR. @AllanOcelot are you able to get that in and refresh the screenshots?
|
Closing in favour of the newer styling update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey gang,
I've just done some simple styling, let me know if this is the right direction and I'll work on some more 'advanced' tweaks I'd like to do to bring some life to the site. I think if the site looks more polished, more users will continue their open source journey - and that's our end goal <3.
( Let me know if anything is off with formatting / branch names etc as this is my first PR on this project )