space: run space init in github e2e job #378
Conversation
sttts
force-pushed
the
sttts-e2e-init
branch
2 times, most recently
from
ae211c1
to
5411d20
Compare
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
sttts
force-pushed
the
sttts-e2e-init
branch
from
5411d20
to
9f63b3b
Compare
| @@ -31,8 +31,8 @@ type authorizedRegistryFlags struct { | |||
| registryFlags | |||
|
|
|||
| TokenFile *os.File `name:"token-file" help:"File containing authentication token."` | |||
| Username string `hidden:"" name:"registry-username" help:"Set the registry username."` | |||
| Password string `hidden:"" name:"registry-password" help:"Set the registry password."` | |||
| Username string `hidden:"" name:"registry-username" env:"UPBOUND_REGISTRY_USERNAME" help:"Set the registry username."` | |||
There was a problem hiding this comment.
I think we'll need to adjust the logic in
Line 49 in c895d1c
There was a problem hiding this comment.
don't think so. Having those env vars should be enough.
| e2e-tests: | ||
| runs-on: ubuntu-20.04 | ||
| #runs-on: | ||
| # group: managed-control-planes-testing |
There was a problem hiding this comment.
Given that we're just installing spaces and not creating control planes, we may not need this yet.
| --yes | ||
| env: | ||
| UPBOUND_REGISTRY_USERNAME: ${{ secrets.DOCKER_USR }} | ||
| UPBOUND_REGISTRY_PASSWORD: ${{ secrets.DOCKER_PSW }} |
There was a problem hiding this comment.
@tnthornton is this supposed to work? Do these variables exist? I lack permissions to see the secrets in the repo and the org.
There was a problem hiding this comment.
@sttts they appear to. (both on the settings page and because 'login to docker' passed in main https://github.com/upbound/up/actions/runs/6318356855/job/17157170338).
There was a problem hiding this comment.
Oh you know what, those creds are probably not available to PRs from forks.
There was a problem hiding this comment.
Oh you know what, those creds are probably not available to PRs from forks.
This is the case. GH does not allow forks to use the creds to prevent malicious PR's from exfiltrating secrets.
Smoke test for
up space init. To be extended, e.g. moved into a real test suite.