Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In order to minimize patches, I've added ability to disable apollo tracing extension,
which drammatically shrinks patch responses. Additionally, the previous implementation
suffered from inconsistent throttling because between producing graphql response
marshaller and it actually marshalling into output, there could be a non-trivial
delay due to all fields getting resolved during marshalling. Finally, the original
implementation would swallow context errors, since there is no way to add errors to
streaming responses channel.
With this implementation, we don't generate liveQuery resolver, relying on a gqlgen
operation interceptor extension. When an operation is detected to be a liveQuery
subscription field, it is replaced with a query equivalent and the handler re-runs
the query in a loop with throttle backoff.
I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Tested locally.