Fix excess memory consumption #141
Merged
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalanche123
approved these changes
Sep 25, 2024
- make hash generation for client-id deterministic - remove bearertoken as that is regenerated every 90s
tnthornton
force-pushed
the
client-cache-memory-leak
branch
from
7de040f to
f7b96fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This fixes a problem we were seeing where the same requester was identified as different clients resulting in excess informer cache accumulation and unbounded heap growth.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Deployed the changes out to some Upbound control planes and verified (through logging) that the client cache remained small and that memory and cpu did not grow unbounded (via metrics).