-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickup at penn #39
Open
magibney
wants to merge
77
commits into
35-colenda-bento-preview
Choose a base branch
from
pickup_at_penn
base: 35-colenda-bento-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pickup at penn #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're getting a bunch of extra unique values from other institutions' records, blowing out the filterCache and killing performance. This is a temporary workaround until we can figure out how to fix format for other record sources
no differentiation in source/type/ontology for now; they're just strings, linked/searched as strings, so there is no point whatsoever in duplicating them for display.
Co-authored-by: Iva Goldsmith <[email protected]>
This line was copy-pasted from elsewhere, and doesn't work for responses from Colenda.
This reverts commit b780c4f.
…il, Request=>Pickup@Penn) To undo to pre-covid state, this commit may be reverted atomically.
tampakis
force-pushed
the
35-colenda-bento-preview
branch
from
August 14, 2020 12:55
cad65fc
to
d88494e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for testing with auth/etc.